From 41a9133d3d02c2d2948fbfe7599c10bfbd2aed2d Mon Sep 17 00:00:00 2001 From: Morgan Astra Date: Wed, 14 Nov 2018 14:28:15 -0800 Subject: [PATCH] Add fixme notes --- src/pronouns/pages.clj | 4 ++++ src/pronouns/web.clj | 10 ++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/pronouns/pages.clj b/src/pronouns/pages.clj index 5782df4..2ae6b4e 100644 --- a/src/pronouns/pages.clj +++ b/src/pronouns/pages.clj @@ -34,6 +34,8 @@ [url text] [:a {:href url} text]) +;; FIXME morgan.astra <2018-11-14 Wed> +;; use a div for this instead of a plain bold tag (defn wrap-pronoun [pronoun] [:b pronoun]) @@ -90,6 +92,8 @@ (defn usage-block [] [:div {:class "section usage"} [:p "Full usage: " + ;; FIXME morgan.astra <2018-11-14 Wed> + ;; This looks really ugly in the browser [:tt "https://pronoun.is/subject-pronoun/object-pronoun/possessive-determiner/possessive-pronoun/reflexive"] " displays examples of your pronouns."] [:p "This is a bit unwieldy. If we have a good guess we'll let you use" diff --git a/src/pronouns/web.clj b/src/pronouns/web.clj index 83a184d..15057c2 100644 --- a/src/pronouns/web.clj +++ b/src/pronouns/web.clj @@ -21,7 +21,9 @@ [clojure.string :as s] [clojure.java.io :as io] [ring.adapter.jetty :as jetty] - ;[ring.middleware.logger :as logger] + ;; FIXME morgan.astra <2018-11-14 Wed> + ;; make this logger work or use another one + ;; [ring.middleware.logger :as logger] [ring.middleware.stacktrace :as trace] [ring.middleware.params :as params] [ring.middleware.resource :refer [wrap-resource]] @@ -66,9 +68,13 @@ (def app (-> app-routes - (wrap-resource "images") + ;; FIXME morgan.astra <2018-11-14 Wed> + ;; use this resource or delete it + ;; (wrap-resource "images") wrap-content-type wrap-not-modified + ;; FIXME morgan.astra <2018-11-14 Wed> + ;; make this logger work or use another one ;logger/wrap-with-logger wrap-error-page wrap-gnu-natalie-nguyen